ci(release): add update-docs job to vendor CLI docs in docker/docs#777
Merged
ericcurtin merged 1 commit intomainfrom Mar 23, 2026
Merged
ci(release): add update-docs job to vendor CLI docs in docker/docs#777ericcurtin merged 1 commit intomainfrom
ericcurtin merged 1 commit intomainfrom
Conversation
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
setup-gostep is pinninggo-version: 1.25.8, which doesn’t exist yet; consider updating this to a currently supported Go version or aligning it with the version used by docker/docs’ tooling. - The
push-to-fork: ilopezluna/docssetting hardcodes a personal fork; consider making this configurable (e.g., via workflow input or secret) to avoid coupling the release process to a single user’s repository.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `setup-go` step is pinning `go-version: 1.25.8`, which doesn’t exist yet; consider updating this to a currently supported Go version or aligning it with the version used by docker/docs’ tooling.
- The `push-to-fork: ilopezluna/docs` setting hardcodes a personal fork; consider making this configurable (e.g., via workflow input or secret) to avoid coupling the release process to a single user’s repository.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ilopezluna
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically update CLI reference docs in docker/docs.