Skip to content

fix: optimize latest release tag retrieval in release.yml#896

Merged
ilopezluna merged 1 commit into
mainfrom
fix-resolve-last-tag
Apr 30, 2026
Merged

fix: optimize latest release tag retrieval in release.yml#896
ilopezluna merged 1 commit into
mainfrom
fix-resolve-last-tag

Conversation

@ilopezluna
Copy link
Copy Markdown
Contributor

Previous code to resolve latest tag was unnecessarily complex and also it was wrong:

LATEST_RELEASE_TAG=$(gh release list --limit 100 --json tagName \
            --jq '[.[] | select(.tagName | startswith("v"))] | sort_by(.tagName) | last | .tagName // ""' \
            2>/dev/null || echo "")
ilopezluna@F2D5QD4D6C model-runner % echo $LATEST_RELEASE_TAG                                         
v1.1.9            

And it should be v1.1.37:

gh release list --limit 1  
TITLE                        TYPE    TAG NAME  PUBLISHED       
Docker Model Runner v1.1.37  Latest  v1.1.37   about 8 days ago

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@ilopezluna ilopezluna requested a review from a team April 30, 2026 11:48
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ilopezluna ilopezluna merged commit 54a79a0 into main Apr 30, 2026
14 checks passed
@ilopezluna ilopezluna deleted the fix-resolve-last-tag branch April 30, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants