Log Hub response in llama-server auto update failure path#92
Merged
Conversation
In case Hub responds with an unexpected tag (or other unexpected content) when querying for the desired llama-server tag during the auto update process, we return an ok error, but extra info would be nice for debugging. So add a log entry in case the Hub response does not contain the desired tag. Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@docker.com>
doringeman
approved these changes
Jun 25, 2025
ilopezluna
approved these changes
Jun 25, 2025
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 23, 2025
Signed-off-by: Emily Casey <emily.casey@docker.com>
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 23, 2025
Signed-off-by: Emily Casey <emily.casey@docker.com>
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 24, 2025
Signed-off-by: Emily Casey <emily.casey@docker.com>
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 24, 2025
Signed-off-by: Emily Casey <emily.casey@docker.com>
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Oct 2, 2025
Bump Moby-related projects to v28.2.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case Hub responds with an unexpected tag (or other unexpected content) when querying for the desired llama-server tag during the auto update process, we return an ok error, but extra info would be nice for debugging. So add a log entry in case the Hub response does not contain the desired tag.