Use modelID instead of model tag#98
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… of the runner. Currently the slot and the model reference used.
xenoscopic
reviewed
Jul 7, 2025
| } | ||
|
|
||
| func (r *OpenAIRecorder) RecordRequest(model string, req *http.Request, body []byte) string { | ||
| modelID := r.modelManager.ResolveModelID(model) |
Contributor
There was a problem hiding this comment.
Does using the model ID in the OpenAIRecorder mean that the GUI that displays these requests will also display the SHA256? Or do we resolve it back to the "friendly" name? (Or something like ai/gemma3@sha256:a484b...?)
Contributor
Author
There was a problem hiding this comment.
Currently the UI does not uses/show tags when using a model or inspecting a model. Behind the scenes uses the model ID but the UI does not show that.
With @doringeman we mentioned that we are going to need a ResolveModelTags(model reference) to also show all the available tags eventually of a local model.
# Conflicts: # pkg/inference/scheduling/scheduler.go
xenoscopic
approved these changes
Jul 14, 2025
doringeman
approved these changes
Jul 14, 2025
xenoscopic
added a commit
that referenced
this pull request
Jul 23, 2025
Follow-up to #98. Signed-off-by: Jacob Howard <jacob.howard@docker.com>
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 23, 2025
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For actions with models:
Use the model ID (digest) instead of the tag.
This has several benefits, like we don't need to unload/load the same model if user specifies different tag.
Also this PR include the actual reference used when running a model, to use it when doing
docker model psto mimic the behavior ofdocker ps, if you run an image with multiple tags, thedocker pscommand will show you the tag used