keychain/darwin: should not error on delete when item not found

Benehiko · Benehiko · commit 82638e36b009 · 2025-06-30T17:01:06.000+02:00
Signed-off-by: Alano Terblanche &lt;18033717+Benehiko@users.noreply.github.com&gt;
diff --git a/store/keychain/keychain_darwin.go b/store/keychain/keychain_darwin.go
@@ -68,7 +68,11 @@ func (k *keychainStore[T]) Delete(ctx context.Context, id store.ID) error {
 	}
 
 	item := newKeychainItem(id.String(), k)
-	return mapKeychainError(kc.DeleteItem(item))
+	err := kc.DeleteItem(item)
+	if err != nil && !errors.Is(err, kc.ErrorItemNotFound) {
+		return mapKeychainError(err)
+	}
+	return nil
 }
 
 func (k *keychainStore[T]) Get(ctx context.Context, id store.ID) (store.Secret, error) {

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,11 @@ func (k *keychainStore[T]) Delete(ctx context.Context, id store.ID) error {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`item := newKeychainItem(id.String(), k)`
`71`		`- return mapKeychainError(kc.DeleteItem(item))`
	`71`	`+ err := kc.DeleteItem(item)`
	`72`	`+ if err != nil && !errors.Is(err, kc.ErrorItemNotFound) {`
	`73`	`+ return mapKeychainError(err)`
	`74`	`+ }`
	`75`	`+ return nil`
`72`	`76`	`}`
`73`	`77`
`74`	`78`	`func (k *keychainStore[T]) Get(ctx context.Context, id store.ID) (store.Secret, error) {`