store/keychain: comment why we don't error on id parse in filter

Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>

Author: Benehiko

store/keychain/keychain_darwin.go

@@ -200,6 +200,12 @@ func (k *keychainStore[T]) Filter(_ context.Context, pattern store.Pattern) (map
 
 	creds := make(map[string]store.Secret)
 	for _, result := range results {
+		// it is possible that someone else has stored secrets in the keychain
+		// directly without conforming to the store.ID format.
+		// We shouldn't error here when these values cannot be retrieved or
+		// parsed. Instead we just ignore them and proceed.
+		// I guess in future we could at least log them somewhere?
+		// but for now, let's just continue with the other items in the store.
 		id, err := store.ParseID(result.Account)
 		if err != nil {
 			continue

store/keychain/keychain_linux.go

@@ -368,6 +368,12 @@ func (k *keychainStore[T]) Filter(_ context.Context, pattern store.Pattern) (map
 			return nil, err
 		}
 
+		// it is possible that someone else has stored secrets in the keychain
+		// directly without conforming to the store.ID format.
+		// We shouldn't error here when these values cannot be retrieved or
+		// parsed. Instead we just ignore them and proceed.
+		// I guess in future we could at least log them somewhere?
+		// but for now, let's just continue with the other items in the store.
 		attrID, ok := attributes["id"]
 		if !ok {
 			continue

store/keychain/keychain_windows.go

@@ -210,6 +210,12 @@ func (k *keychainStore[T]) Filter(_ context.Context, pattern store.Pattern) (map
 
 	secrets := make(map[string]store.Secret)
 	for cred := range findServiceCredentials(k, pattern, credentials) {
+		// it is possible that someone else has stored secrets in the keychain
+		// directly without conforming to the store.ID format.
+		// We shouldn't error here when these values cannot be retrieved or
+		// parsed. Instead we just ignore them and proceed.
+		// I guess in future we could at least log them somewhere?
+		// but for now, let's just continue with the other items in the store.
 		id, err := store.ParseID(strings.ReplaceAll(cred.TargetName, onlyLabelPrefix, ""))
 		if err != nil {
 			continue