Modernize tests

.golangci.yml

@@ -3,6 +3,7 @@ linters:
   default: none
   enable:
     - errcheck
+    - forbidigo
     - gocyclo
     - govet
     - ineffassign
@@ -16,6 +17,12 @@ linters:
     - unparam
     - unused
   settings:
+    forbidigo:
+      forbid:
+        - pattern: '^os\.MkdirTemp$'
+          msg: "use t.TempDir() instead"
+        - pattern: '^context\.(Background|TODO)$'
+          msg: "use t.Context() instead"
     gocritic:
       disabled-checks:
         - dupArg
@@ -44,6 +51,12 @@ linters:
       - builtin$
       - examples$
       - vendor$
+    rules:
+      # Scope test-specific forbidigo rules to test files only
+      - path: '_test\.go$'
+        linters:
+          - forbidigo
+        text: 'use t\.'
 formatters:
   enable:
     - gofumpt

engine/internal/runtime/plugin_test.go

@@ -76,7 +76,7 @@ func Test_newPlugin(t *testing.T) {
 				assert.Equal(t, pluginNameFromTestName(t), p.Name().String())
 				assert.Equal(t, version.String(), p.Version().String())
 				assert.Equal(t, pattern, p.Pattern().String())
-				s, err := p.GetSecrets(context.Background(), testdummy.MockSecretPattern)
+				s, err := p.GetSecrets(t.Context(), testdummy.MockSecretPattern)
 				require.NoError(t, err)
 				require.NotEmpty(t, s)
 				assert.Equal(t, testdummy.MockSecretValue, string(s[0].Value))
@@ -108,7 +108,7 @@ func Test_newPlugin(t *testing.T) {
 					cmd,
 				)
 				require.NoError(t, err)
-				_, err = p.GetSecrets(context.Background(), testdummy.MockSecretPattern)
+				_, err = p.GetSecrets(t.Context(), testdummy.MockSecretPattern)
 				assert.ErrorContains(t, err, errGetSecret)
 				assert.NoError(t, p.Close())
 				r, err := parseOutput()
@@ -181,12 +181,12 @@ func Test_newPlugin(t *testing.T) {
 					cmd,
 				)
 				require.NoError(t, err)
-				_, err = p.GetSecrets(context.Background(), testdummy.MockSecretPattern)
+				_, err = p.GetSecrets(t.Context(), testdummy.MockSecretPattern)
 				require.NoError(t, err)
 				require.NoError(t, p.Watcher().Kill())
 				assert.NoError(t, testhelper.WaitForClosedWithTimeout(p.Closed()))
 				assert.ErrorContains(t, p.Close(), "stopped unexpectedly")
-				_, err = p.GetSecrets(context.Background(), testdummy.MockSecretPattern)
+				_, err = p.GetSecrets(t.Context(), testdummy.MockSecretPattern)
 				assert.ErrorIs(t, err, yamux.ErrSessionShutdown)
 				_, err = parseOutput()
 				assert.ErrorContains(t, err, "failed to unmarshal ''")

store/keychain/keychain_test.go

@@ -1,7 +1,6 @@
 package keychain
 
 import (
-	"context"
 	"errors"
 	"testing"
 
@@ -72,7 +71,7 @@ func TestKeychain(t *testing.T) {
 			Password: "bob-password",
 		}
 		t.Cleanup(func() {
-			require.NoError(t, ks.Delete(context.Background(), id))
+			require.NoError(t, ks.Delete(t.Context(), id))
 		})
 		require.NoError(t, ks.Save(t.Context(), id, creds))
 	})
@@ -85,7 +84,7 @@ func TestKeychain(t *testing.T) {
 			Password: "bob-password",
 		}
 		t.Cleanup(func() {
-			require.NoError(t, ks.Delete(context.Background(), id))
+			require.NoError(t, ks.Delete(t.Context(), id))
 		})
 		require.NoError(t, ks.Save(t.Context(), id, creds))
 		secret, err := ks.Get(t.Context(), id)
@@ -125,7 +124,7 @@ func TestKeychain(t *testing.T) {
 		}
 		t.Cleanup(func() {
 			for id := range moreCreds {
-				require.NoError(t, ks.Delete(context.Background(), id))
+				require.NoError(t, ks.Delete(t.Context(), id))
 			}
 		})
 
@@ -272,7 +271,7 @@ func TestKeychain(t *testing.T) {
 		id, err := store.ParseID("something/will/fail")
 		require.NoError(t, err)
 		t.Cleanup(func() {
-			require.NoError(t, kc.Delete(context.Background(), id))
+			require.NoError(t, kc.Delete(t.Context(), id))
 		})
 		require.NoError(t, kc.Save(t.Context(), id, &mustUnmarshalError{}))
 		_, err = kc.Get(t.Context(), id)
@@ -286,7 +285,7 @@ func TestKeychain(t *testing.T) {
 		id, err := store.ParseID("something/will/fail")
 		require.NoError(t, err)
 		t.Cleanup(func() {
-			require.NoError(t, kc.Delete(context.Background(), id))
+			require.NoError(t, kc.Delete(t.Context(), id))
 		})
 		require.NoError(t, kc.Save(t.Context(), id, &mustUnmarshalError{}))
 		_, err = kc.GetAllMetadata(t.Context())