Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Signed-off-by: Johannes Großmann <grossmann.johannes@t-online.de>
|
/review |
| Use: "pass [OPTIONS]", | ||
| Use: "pass [OPTIONS]", | ||
| Short: "Manage your local OS keychain secrets.", | ||
| Long: `Docker Pass is an experimental utility for managing secrets in your |
There was a problem hiding this comment.
[MEDIUM] Long descriptions are never rendered — {{.Long}} missing from helpTemplate
The Long descriptions added in this PR (for the root command and all four subcommands: get, set, list, rm) will never appear in CLI help output.
Root cause: The custom helpTemplate defined in command.go (set via cmd.SetHelpTemplate) does not include {{.Long}}. Cobra propagates the parent's help template to all child commands unless they override it, and none of the subcommands set their own template. As a result, running docker pass --help, docker pass get --help, etc. silently drops every Long description.
Impact: All the documentation effort in this PR is functionally dead code — users will never see those detailed descriptions through the CLI.
Fix: Either add {{if .Long}}{{.Long}}\n\n{{end}} to the helpTemplate in command.go, or remove the Long fields if only Short is needed and external doc generation is not planned.
2 participants
No description provided.