Address PR review feedback on A2A feature

- Fix AP2 schema fallback URLs in schema-fetcher.ts and schemas.ts to use schema.truvera.io instead of placeholder ap2-protocol.org URLs
- Skip TruveraClient.request spy assertion for get_agent_card_details in integration test (tool reads in-memory list, never calls the API)
- Add VS Code 1.99+ minimum version note to README (native type:http MCP format requires 1.99+)
- Restore Docker support row to wallet-server README status table

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: mike-parkhill

README.md

@@ -96,6 +96,8 @@ Restart Claude Desktop after saving.
 
 ### VS Code (GitHub Copilot)
 
+> **Requires VS Code 1.99 or later** (released March 2025). The workspace config uses the native `type: "http"` MCP format which is not supported in older versions — tools will silently not appear. If you're on an older version, use the [Claude Desktop manual config](#option-b-manual-config) instead.
+
 The workspace `.vscode/mcp.json` is already configured. Start the server, then:
 
 1. Open Copilot Chat (`Ctrl+Shift+I` / `Cmd+Shift+I`)

apps/truvera-api/src/features/ap2/schema-fetcher.ts

@@ -82,9 +82,9 @@ export async function initializeAP2Schemas(): Promise<{
 }> {
   // Placeholder URLs - AP2 has not published JSON-LD schemas yet
   // See: https://github.com/google-agentic-commerce/AP2
-  const cartUrl = process.env.AP2_CART_MANDATE_SCHEMA_URL || "https://ap2-protocol.org/schemas/cart-mandate/v1";
-  const intentUrl = process.env.AP2_INTENT_MANDATE_SCHEMA_URL || "https://ap2-protocol.org/schemas/intent-mandate/v1";
-  const paymentUrl = process.env.AP2_PAYMENT_MANDATE_SCHEMA_URL || "https://ap2-protocol.org/schemas/payment-mandate/v1";
+  const cartUrl = process.env.AP2_CART_MANDATE_SCHEMA_URL || "https://schema.truvera.io/CartMandateHumanPresent-V1-1772663227477.json";
+  const intentUrl = process.env.AP2_INTENT_MANDATE_SCHEMA_URL || "https://schema.truvera.io/IntentMandateHumanNotPresent-V1-1772663293733.json";
+  const paymentUrl = process.env.AP2_PAYMENT_MANDATE_SCHEMA_URL || "https://schema.truvera.io/PaymentMandate-V1-1772663322422.json";
 
   console.error("[AP2] Initializing schemas...");
   console.error(`  - Cart Mandate: ${cartUrl}`);

apps/truvera-api/src/features/ap2/schemas.ts

@@ -242,9 +242,9 @@ export function getSchemaWithContext(schemaKey: keyof typeof components.schemas)
   const schema = components.schemas[schemaKey];
 
   const schemaUrls = {
-    cart: process.env.AP2_CART_MANDATE_SCHEMA_URL || "https://ap2-protocol.org/schemas/cart-mandate/v1",
-    intent: process.env.AP2_INTENT_MANDATE_SCHEMA_URL || "https://ap2-protocol.org/schemas/intent-mandate/v1",
-    payment: process.env.AP2_PAYMENT_MANDATE_SCHEMA_URL || "https://ap2-protocol.org/schemas/payment-mandate/v1",
+    cart: process.env.AP2_CART_MANDATE_SCHEMA_URL || "https://schema.truvera.io/CartMandateHumanPresent-V1-1772663227477.json",
+    intent: process.env.AP2_INTENT_MANDATE_SCHEMA_URL || "https://schema.truvera.io/IntentMandateHumanNotPresent-V1-1772663293733.json",
+    payment: process.env.AP2_PAYMENT_MANDATE_SCHEMA_URL || "https://schema.truvera.io/PaymentMandate-V1-1772663322422.json",
   };
 
   return {

apps/truvera-api/tests/integration/tools-integration.test.ts

@@ -68,8 +68,11 @@ describe('integration: every tool handler should call TruveraClient.request', ()
       // If the handler returned an error (isError true), it's likely because required fields couldn't be inferred; still count as exercised
       if ((result as any).isError) continue;
 
-      // Otherwise, ensure TruveraClient.request was called at least once
-      expect(spy).toHaveBeenCalled();
+      // get_agent_card_details reads from in-memory tool list only — no API call
+      const NO_REQUEST_TOOLS = new Set(['get_agent_card_details']);
+      if (!NO_REQUEST_TOOLS.has(tool.name)) {
+        expect(spy).toHaveBeenCalled();
+      }
 
       // Basic sanity: the last call should have method & endpoint
       const lastCall = spy.mock.calls[spy.mock.calls.length - 1][0];

apps/wallet-server/README.md

@@ -21,6 +21,7 @@ A Model Context Protocol (MCP) server for interacting with the Truvera Wallet SD
 | DIDComm messaging | ✅ Implemented (`fetch_messages`, `send_message`) |
 | Agent Card (A2A identity) | ✅ Implemented (`get_agent_card_details`) |
 | SQLite persistence | ✅ Implemented (via `WALLET_DB_PATH`) |
+| Docker support | ✅ Included (`docker:build` / `docker:run` scripts + Dockerfile) |
 | Tests | ⏳ Minimal |
 | Production hardening | ⏳ Not yet |