Fix EDV Uint8Array serialization and support mnemonic-based wallet initialization#462
Merged
Conversation
maycon-mello
commented
Mar 12, 2026
maycon-mello
commented
Collaborator
- Fixing JSON-RPC serialization issues where Uint8Array gets converted to plain objects
- Adding initializeFromMnemonic and initializeFromMasterKey methods to the EDV service, allowing cloud wallet init directly with a mnemonic
maycon-mello
force-pushed
the
fix/cloud-wallet-sync
branch
from
March 12, 2026 18:16
bf9e0da to
da71639
Compare
mike-parkhill
left a comment
mike-parkhill
left a comment
Contributor
There was a problem hiding this comment.
any tests we should add?
a couple of linting errors
mike-parkhill
previously approved these changes
Mar 13, 2026
mike-parkhill
left a comment
mike-parkhill
left a comment
Contributor
There was a problem hiding this comment.
lgtm, but still some linting issues being flagged
mike-parkhill
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.