fix: remove private key from wallet logs#544
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the risk of leaking sensitive wallet material by removing verbose logging that could include private keys (via full document dumps) and replacing it with safe, high-level diagnostics.
Changes:
- Replace RPC wallet storage “existing storage found” log from full JSON dump to a document count.
- Remove logging of the full RPC storage payload on error.
- Update
keyDocToKeypairerror message to avoid embedding the fullkeyDoc(which may contain private key material).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/wasm/src/wallet/rpc-storage-interface.js | Stops logging full storage contents; logs only document counts in load/find paths. |
| packages/wasm/src/services/credential/utils.js | Sanitizes the “missing private key” error message to avoid dumping key documents. |
Comments suppressed due to low confidence (1)
packages/wasm/src/wallet/rpc-storage-interface.js:93
findnow callsObject.keys(this.documents || {})twice (once for logging and once to build the result), which needlessly iterates all document IDs twice. You can compute the keys once and reuse them for both logging and mapping.
async find({has = undefined, equals = undefined} = {}) {
Logger.debug('Execute find', {
equals,
documentCount: Object.keys(this.documents || {}).length,
});
const documents = Object.keys(this.documents || {})
.map(docId => {
const content = this.documents[docId];
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mike-parkhill
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.