Skip to content

fix: remove private key from wallet logs #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maycon-mello merged 3 commits into from
Jun 22, 2026
Merged

fix: remove private key from wallet logs #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d59b5bf
fix: remove private key material from wallet logs (DCKA-5512)
maycon-mello Jun 22, 2026
03fbe54
fix: address PR review comments on private key logging
maycon-mello Jun 22, 2026
da7de47
Merge branch 'master' into dcka-5512-remove-private-key-from-logs
maycon-mello Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/wasm/src/services/credential/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,9 @@ export async function keyDocToKeypair(keyDoc) {
privateKeyBase58 || (privateKeyMultibase && privateKeyMultibase.substr(1));
if (!privateKeyEncoded) {
throw new Error(
`No private key in document found, this should not happen. Got: ${JSON.stringify(
keyDoc,
null,
2,
)}`,
`No private key in document found, this should not happen. keyDoc id: ${
keyDoc.id || '<unknown>'
}, type: ${type || '<unknown>'}`,
);
Comment thread
maycon-mello marked this conversation as resolved.
}

Expand Down
13 changes: 9 additions & 4 deletions packages/wasm/src/wallet/rpc-storage-interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,16 @@ class RpcStorageInterface extends StorageInterface {
Logger.debug('Wallet: no storage found, creating empty wallet');
this.documents = {};
} else {
Logger.debug(`Wallet: existing storage found: ${JSON.stringify(data)}`);
Logger.debug(
`Wallet: existing storage found with ${
Object.keys(this.documents).length
} documents`,
);
}
} catch (err) {
Logger.error(
`error to retrieve data from rpc storage: ${err.toString()}`,
);
Logger.info(JSON.stringify(data));
this.documents = {};

throw err;
Expand Down Expand Up @@ -80,12 +83,14 @@ class RpcStorageInterface extends StorageInterface {
}

async find({has = undefined, equals = undefined} = {}) {
const documentIds = Object.keys(this.documents || {});

Logger.debug('Execute find', {
equals,
documents: this.documents,
documentCount: documentIds.length,
});

const documents = Object.keys(this.documents || {})
const documents = documentIds
.map(docId => {
const content = this.documents[docId];

Expand Down
Loading