Skip to content

fixing presentation errors for re-delegated credentials - #561

Merged
maycon-mello merged 3 commits into
masterfrom
fix/presentation-creation-for-re-delegated-credentials
Jul 21, 2026
Merged

fixing presentation errors for re-delegated credentials#561
maycon-mello merged 3 commits into
masterfrom
fix/presentation-creation-for-re-delegated-credentials

Conversation

@maycon-mello

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes verifiable presentation generation issues when working with re-delegated credentials by tightening BBS+ credential detection and ensuring signed presentations are returned as plain JSON (avoiding class-instance serialization pitfalls). Adds an integration test and fixture to reproduce the delegated-credential flow.

Changes:

  • Update isBBSPlusCredential to rely on proof.type (instead of @context) to avoid misclassifying non-BBS credentials that include BBS-related contexts.
  • Normalize presentation creation to return signed.toJSON() after signing.
  • Add an integration test + delegated credential fixture to cover the delegated verification flow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/wasm/src/services/credential/service.ts Adjusts BBS+ detection and returns signed presentations as JSON to prevent presentation serialization/format errors.
integration-tests/verification-flow/delegatable-verification.test.ts Adds an integration test covering default presentation creation for a delegated credential.
integration-tests/data/default-presentation-tests/delegated-credential.json Adds a delegated credential fixture used by the new integration test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread integration-tests/verification-flow/delegatable-verification.test.ts Outdated
Comment thread integration-tests/verification-flow/delegatable-verification.test.ts Outdated
maycon-mello and others added 2 commits July 21, 2026 13:47
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@maycon-mello
maycon-mello merged commit ddfe62d into master Jul 21, 2026
7 checks passed
@maycon-mello
maycon-mello deleted the fix/presentation-creation-for-re-delegated-credentials branch July 21, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants