fixing presentation errors for re-delegated credentials - #561
Merged
maycon-mello merged 3 commits intoJul 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes verifiable presentation generation issues when working with re-delegated credentials by tightening BBS+ credential detection and ensuring signed presentations are returned as plain JSON (avoiding class-instance serialization pitfalls). Adds an integration test and fixture to reproduce the delegated-credential flow.
Changes:
- Update
isBBSPlusCredentialto rely onproof.type(instead of@context) to avoid misclassifying non-BBS credentials that include BBS-related contexts. - Normalize presentation creation to return
signed.toJSON()after signing. - Add an integration test + delegated credential fixture to cover the delegated verification flow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/wasm/src/services/credential/service.ts | Adjusts BBS+ detection and returns signed presentations as JSON to prevent presentation serialization/format errors. |
| integration-tests/verification-flow/delegatable-verification.test.ts | Adds an integration test covering default presentation creation for a delegated credential. |
| integration-tests/data/default-presentation-tests/delegated-credential.json | Adds a delegated credential fixture used by the new integration test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mike-parkhill
approved these changes
Jul 21, 2026
maycon-mello
deleted the
fix/presentation-creation-for-re-delegated-credentials
branch
July 21, 2026 18:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.