fix/delegation chain document - #563
Merged
Merged
Conversation
maycon-mello
commented
Jul 23, 2026
maycon-mello
commented
Collaborator
- should not add delegation chain document to the credential store
maycon-mello
force-pushed
the
fix/delegation-chain-document
branch
from
July 23, 2026 13:07
5278ff4 to
5510d3a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the delegation offer issuance flow to avoid persisting delegation-chain ancestor credentials into the holder’s credential store, while still retaining delegation-chain information in the wallet for later use.
Changes:
- Replaces per-ancestor
addDocumentpersistence with a single stored delegation-chain document on receipt of an issued delegated credential. - Updates the integration test to assert only the delegated credential is present in the credential store and that the chain is stored separately.
- Renames the received issuance message variable for clarity in the integration test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/delegation/delegation-offer.ts | Changes how delegation-chain data is persisted when handling issue-credential messages. |
| integration-tests/delegation-offer.test.ts | Extends assertions to ensure delegation-chain ancestors are not added to the credential store and validates the stored chain document. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mike-parkhill
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.