Skip to content

persist the delegated credential in the offer for revocation purposes #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maycon-mello merged 5 commits into from
Jul 28, 2026
Merged

persist the delegated credential in the offer for revocation purposes #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8eba3b
persist delegated credential in the offer for revocation purposes
maycon-mello Jul 28, 2026
f4af68e
persist delegated credential in the offer for revocation purposes
maycon-mello Jul 28, 2026
caf87d7
persist delegated credential in the offer for revocation purposes
maycon-mello Jul 28, 2026
81520ae
refactoring
maycon-mello Jul 28, 2026
e61dda5
assert revocationData is present in the delegation offer document
maycon-mello Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions integration-tests/delegation-offer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ describe('Credential Distribution', () => {
expect(updatedOffer.type).toContain('DelegationOffer');
expect(updatedOffer.status).toBe('accepted');
expect(updatedOffer.holderDID).toBe(holderWallet.did);
expect(updatedOffer.revocationData.credentialId).toBeDefined();
expect(updatedOffer.revocationData.credentialStatus).toBeDefined();

// Step 4: Holder receive the delegatable credential from the issuer
const delegationIssuanceMessage =
Expand Down
7 changes: 7 additions & 0 deletions integration-tests/helpers/wallet-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,18 @@ type FullWalletClient = {
messageProvider: IMessageProvider;
}

const SPONSOR_KEY = process.env.TRUVERA_API_SPONSOR_KEY;
const API_URL = process.env.DELEGATION_REVOCATION_API_URL;

export async function createFullWalletClient(): Promise<FullWalletClient> {
const dataStore = await createDataStore({
databasePath: ':memory:',
dbType: 'sqlite',
defaultNetwork: 'testnet',
truveraApi: {
authKey: SPONSOR_KEY,
apiUrl: API_URL,
}
});
const wallet = await createWallet({
dataStore,
Expand Down
8 changes: 8 additions & 0 deletions packages/core/src/delegation/delegation-offer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,14 @@ export const DELEGATION_REQUEST_HANDLER = {
},
});

// Persist revocation data on the delegation offer so the issuer can update it when revoking.
delegationOffer.revocationData = {

@mike-parkhill mike-parkhill Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add tests to validate this is being stored? If so, I'd expect them to fail after this refactor

@maycon-mello maycon-mello Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have revocation tests which is calling the revocation helpers directly and has access to the full credential. I just updated the test to ensure we assert the revocation data is there.

credentialStatus: delegatedCredential.credentialStatus,
credentialId: delegatedCredential.id,
};

await wallet.updateDocument(delegationOffer);
Comment thread
mike-parkhill marked this conversation as resolved.

const delegationChain = await getDelegationChain(parentCredential, wallet);

await messageProvider.sendMessage({
Expand Down
1 change: 1 addition & 0 deletions packages/data-store/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export async function createDataStore({
const dataStore: DataStore = {
events: new EventEmitter(),
db: dataSource,
configs: configs,
networkId: options.defaultNetwork,
network: options.networks.find(item => item.id === options.defaultNetwork),
testNetworkId: options.testNetworkId,
Expand Down
1 change: 1 addition & 0 deletions packages/data-store/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export type DataStore = {
setNetwork: (networkId: string) => Promise<void>;
documents: DocumentStore;
wallet: WalletStore;
configs: DataStoreConfigs;
};

export type ContextProps = {
Expand Down
Loading