DCKA 5575 web wallet delegation support - #570
Merged
Merged
Conversation
maycon-mello
commented
Jul 29, 2026
maycon-mello
commented
Collaborator
- Add delegation support to web wallet
maycon-mello
force-pushed
the
DCKA-5575-web-wallet-delegation-support
branch
from
July 29, 2026 16:54
2bd5396 to
d07607c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds delegation support to the web wallet SDK by exposing core delegation utilities and providing wallet-bound helpers to participate in delegation DIDComm flows.
Changes:
- Re-export delegation-related APIs (offers, issuance, policy/chain lookup, revocation) from
@docknetwork/wallet-sdk-web. - Add wallet instance helpers:
enableDelegation(),createDelegationOffer(),acceptDelegationOffer(),getDelegationDetails(), andhandleMessage(). - Add Jest coverage for the new exports and wallet-bound delegation behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/web/src/index.js | Imports and re-exports delegation APIs; adds delegation helpers on the initialized wallet instance. |
| packages/web/src/index.test.js | Extends mocks and adds tests for delegation re-exports and wallet-bound delegation helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+693
to
+695
| createDelegationOffer: params => | ||
| createDelegationOffer({wallet, ...params}), | ||
|
|
mike-parkhill
left a comment
mike-parkhill
left a comment
Contributor
There was a problem hiding this comment.
One comment on a comment and there are some linting issues, but otherwise lgtm
mike-parkhill
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.