Skip to content

Dev#591

Open
nicksaven wants to merge 3 commits into
docling-project:mainfrom
nicksaven:dev
Open

Dev#591
nicksaven wants to merge 3 commits into
docling-project:mainfrom
nicksaven:dev

Conversation

@nicksaven

Copy link
Copy Markdown

Adds support for building Docling Serve container images with external Docling plugins installed at image build time, and introduces Surya OCR image targets.

Changes included:

  • add DOCLING_EXTRA_PLUGINS build arg in Containerfile
  • add Surya image targets for base, CUDA 12.8, and CUDA 13.0 builds
  • add reusable image organization variables and branch tag aliasing in Makefile
  • exclude flash-attn from Surya CUDA image targets to avoid runtime failures when the compiled flash_attn_2_cuda extension is unavailable
  • discover OCR engines dynamically in the Gradio UI so external OCR plugins appear automatically
  • add deprecated DOCLING_SERVE_OCR_ENGINE compatibility alias for OCR defaults
  • document OCR control environment variables and update .env.example
  • add tests for OCR env alias behavior

Testing performed:

  • built and ran docling-serve-cu128-surya-image locally
  • verified Surya OCR works in the rebuilt CUDA 12.8 image
  • verified the rebuilt image does not include flash_attn / flash_attn_2_cuda
  • added unit tests for DOCLING_SERVE_OCR_ENGINE fallback behavior

@mergify

mergify Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 1 of 1 protections blocking · waiting on 🙋 you

Protection Waiting on
🔴 Enforce conventional commit 🙋 you

🔴 Enforce conventional commit

Waiting for

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:
This rule is failing.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

DCO Check Failed

Hi @nicksaven, your pull request has failed the Developer Certificate of Origin (DCO) check.

This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format.


🛠 Quick Fix: Add a remediation commit

Run this command:

git commit --allow-empty -s -m "DCO Remediation Commit for Nick Saven <nkt.sav@icloud.com>

I, Nick Saven <nkt.sav@icloud.com>, hereby add my Signed-off-by to this commit: 1f8a8fde164936d1ef00302413abcc4c47a15b39
I, Nick Saven <nkt.sav@icloud.com>, hereby add my Signed-off-by to this commit: 37673e88aa15bfb5985b3030fea9dd4bcdbcd434
I, Nick Saven <nkt.sav@icloud.com>, hereby add my Signed-off-by to this commit: 19e57319b30d9ed0b745d5bdaa2988bfc8d44291"
git push

🔧 Advanced: Sign off each commit directly

For the latest commit:

git commit --amend --signoff
git push --force-with-lease

For multiple commits:

git rebase --signoff origin/main
git push --force-with-lease

More info: DCO check report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant