Skip to content

Commit 155866b

Browse files
committed
fix(ci): build TipTap extensions and apps in PR check
CI workflow (pr-check.yml): - Add build step for all 4 TipTap extensions - Use direct 'npx next build' with NODE_ENV=production - Pass required NEXT_PUBLIC_* env vars for both webapp and admin Pre-push hook (.husky/pre-push): - Add webapp build step (runs if packages/webapp/ changed) - Update admin-dashboard to use direct build (not build:local) - Pass minimal required env vars for build validation - Consistent with CI approach - validates build without real secrets
1 parent b5e938f commit 155866b

2 files changed

Lines changed: 54 additions & 5 deletions

File tree

β€Ž.github/workflows/pr-check.ymlβ€Ž

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,25 @@ jobs:
4444
# - name: πŸ“ Type check (backend)
4545
# run: bun run typecheck:backend
4646

47+
- name: πŸ”§ Build TipTap extensions
48+
run: |
49+
bun run --filter @docs.plus/extension-hyperlink build
50+
bun run --filter @docs.plus/extension-hypermultimedia build
51+
bun run --filter @docs.plus/extension-indent build
52+
bun run --filter @docs.plus/extension-inline-code build
53+
4754
- name: πŸ—οΈ Build webapp
48-
run: bun run --filter @docs.plus/webapp build:local
55+
run: cd packages/webapp && npx next build
4956
env:
57+
NODE_ENV: production
5058
NEXT_PUBLIC_SUPABASE_URL: ${{ secrets.NEXT_PUBLIC_SUPABASE_URL || 'http://localhost:54321' }}
5159
NEXT_PUBLIC_SUPABASE_ANON_KEY: ${{ secrets.NEXT_PUBLIC_SUPABASE_ANON_KEY || 'dummy-key' }}
5260

5361
- name: πŸ—οΈ Build admin
54-
run: bun run --filter @docs.plus/admin-dashboard build:local
62+
run: cd packages/admin-dashboard && npx next build
5563
env:
64+
NODE_ENV: production
5665
NEXT_PUBLIC_SUPABASE_URL: ${{ secrets.NEXT_PUBLIC_SUPABASE_URL || 'http://localhost:54321' }}
5766
NEXT_PUBLIC_SUPABASE_ANON_KEY: ${{ secrets.NEXT_PUBLIC_SUPABASE_ANON_KEY || 'dummy-key' }}
67+
NEXT_PUBLIC_API_URL: http://localhost:3003
68+
NEXT_PUBLIC_APP_URL: http://localhost:3000

β€Ž.husky/pre-pushβ€Ž

Lines changed: 41 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,19 @@ echo ""
5353
# ============================================
5454
if echo "$CHANGED_FILES" | grep -q "packages/admin-dashboard/"; then
5555
echo "πŸ“¦ Building admin-dashboard..."
56-
if bun run --filter "@docs.plus/admin-dashboard" build:local >/dev/null 2>&1; then
56+
# Use direct next build with production mode and minimal env vars
57+
if cd packages/admin-dashboard && \
58+
NODE_ENV=production \
59+
NEXT_PUBLIC_SUPABASE_URL=http://localhost:54321 \
60+
NEXT_PUBLIC_SUPABASE_ANON_KEY=dummy-key-for-build-check \
61+
NEXT_PUBLIC_API_URL=http://localhost:3003 \
62+
NEXT_PUBLIC_APP_URL=http://localhost:3000 \
63+
npx next build >/dev/null 2>&1; then
5764
echo " βœ… admin-dashboard build OK"
65+
cd ../..
5866
else
5967
echo " ❌ admin-dashboard build failed"
68+
cd ../..
6069
FAILED=1
6170
fi
6271
else
@@ -70,6 +79,35 @@ if [ $FAILED -ne 0 ]; then
7079
fi
7180

7281
echo ""
73-
echo "πŸš€ All pre-push checks passed. Proceeding with push."
82+
83+
# ============================================
84+
# 3. Build Webapp (only if changed)
85+
# ============================================
86+
if echo "$CHANGED_FILES" | grep -q "packages/webapp/"; then
87+
echo "πŸ“¦ Building webapp..."
88+
# Use direct next build with production mode and minimal env vars
89+
# (matches CI pr-check workflow - just validates build, not real deployment)
90+
if cd packages/webapp && \
91+
NODE_ENV=production \
92+
NEXT_PUBLIC_SUPABASE_URL=http://localhost:54321 \
93+
NEXT_PUBLIC_SUPABASE_ANON_KEY=dummy-key-for-build-check \
94+
npx next build >/dev/null 2>&1; then
95+
echo " βœ… webapp build OK"
96+
cd ../..
97+
else
98+
echo " ❌ webapp build failed"
99+
cd ../..
100+
FAILED=1
101+
fi
102+
else
103+
echo "πŸ“¦ No webapp changes detected, skipping build"
104+
fi
105+
106+
if [ $FAILED -ne 0 ]; then
107+
echo ""
108+
echo "❌ Webapp build failed. Push aborted."
109+
exit 1
110+
fi
111+
74112
echo ""
75-
echo "πŸ’‘ Note: Webapp build is handled by CI/CD pipeline."
113+
echo "πŸš€ All pre-push checks passed. Proceeding with push."

0 commit comments

Comments
Β (0)