Skip to content

[ScriptUI] onClose _can_ return false to cancel, but it is not required#141

Merged
zlovatt merged 1 commit into
docsforadobe:masterfrom
fartinmartin:events
May 10, 2025
Merged

[ScriptUI] onClose _can_ return false to cancel, but it is not required#141
zlovatt merged 1 commit into
docsforadobe:masterfrom
fartinmartin:events

Conversation

@fartinmartin
Copy link
Copy Markdown
Contributor

The current definition of the onClosed callback says:

...The function is called before the window actually closes; it can return false to cancel the close operation.

But, the type suggests a boolean must be returned:

onClose(): boolean

This PR updates the return type to void | boolean.

@zlovatt zlovatt merged commit 6953648 into docsforadobe:master May 10, 2025
1 check passed
@zlovatt
Copy link
Copy Markdown
Member

zlovatt commented May 10, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants