Skip to content

fix: enhance sidebar navigation link selection for decoded URLs #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sy-records merged 2 commits into from
Apr 2, 2026
Merged

fix: enhance sidebar navigation link selection for decoded URLs #2708

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b15e46b
fix: enhance sidebar navigation link selection for decoded URLs
sy-records Mar 31, 2026
f70137c
fix: simplify sidebar navigation link selection for active route
sy-records Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/core/render/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,11 @@ export function Render(Base) {
sidebarToggleEl.setAttribute('aria-expanded', String(!isMobile()));

const activeElmHref = this.router.toURL(this.route.path);
const decodedHref = decodeURIComponent(activeElmHref);
const activeEl = /** @type {HTMLElement | null} */ (
dom.find(`.sidebar-nav a[href="${activeElmHref}"]`)
dom.find(
`.sidebar-nav a[href="${activeElmHref}"]${activeElmHref !== decodedHref ? `, .sidebar-nav a[href="${decodedHref}"]` : ''}`,
)
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decodeURIComponent(activeElmHref) can throw on malformed percent-encoding (e.g. a user navigates to a hash containing a raw %), which would break sidebar rendering here. Also, using the decoded value directly inside a CSS attribute selector can make querySelector throw if decoding introduces selector-breaking characters like " or \. Consider a safe decode (try/catch + fallback to original) and/or avoid interpolating unescaped URL strings into a selector (e.g., iterate anchors and compare getAttribute('href'), or escape via CSS.escape with a fallback).

Copilot uses AI. Check for mistakes.
);

this.#addTextAsTitleAttribute('.sidebar-nav a');
Expand Down