[Translatable] added selective field translation to the translatable extension#2874
Open
smatyas wants to merge 1 commit into
Open
[Translatable] added selective field translation to the translatable extension#2874smatyas wants to merge 1 commit into
smatyas wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2874 +/- ##
==========================================
+ Coverage 78.75% 78.82% +0.07%
==========================================
Files 163 167 +4
Lines 8593 8643 +50
==========================================
+ Hits 6767 6813 +46
- Misses 1826 1830 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
We still use a custom walker to mitigate this limitation. Is there a chance to merge this any time? If so, we're willing to cover it with tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to solve the problem where the user reaches the mysql join table count limitation due to many translatable fields.
If we have too many, the following mysql error arises:
Certainly, it is not a complete solution for the problem, meaning that we will still be unable to translate every field in one query, but I found it really useful in certain scenarios.
Using this optional hint, the user can be selective about the fields to translate, so it will limit the number of joins to those fields.
Without this, the user have to use different workarounds that makes this extension less useful.
usage example: