Replace the behat/transliterator with symfony/string for the Sluggable extension

[VincentLanglet]

I just rebased #2944 in case it could help.

Closes #2941
Closes #2944

Credits to mbabker

[codecov]

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.55%. Comparing base (3ca38e8) to head (707ef35).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Sluggable/SluggableListener.php	88.88%	2 Missing ⚠️
src/Sluggable/Util/Urlizer.php	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2985      +/-   ##
==========================================
+ Coverage   78.49%   78.55%   +0.05%     
==========================================
  Files         168      169       +1     
  Lines        8813     8828      +15     
==========================================
+ Hits         6918     6935      +17     
+ Misses       1895     1893       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[smnandre]

Suggested change

	- Replace the `behat/transliterator` with `symfony/string` for the Sluggable extension for its default transliteration and urlization steps"
	- Sluggable: Replaced abandoned `behat/transliterator` with `symfony/string` for default transliteration and urlization steps (#2985)

[VincentLanglet]

Thanks updated

[phansys]

Thank you @VincentLanglet, and, special thanks to @mbabker! ❤️

[VincentLanglet]

Thanks you @phansys !

Do you need help to maintain this repository ? 😄

[phansys]

Hey @VincentLanglet!
Of course, help is always welcome.

I don't have the required permissions to add new maintainers in this repository. I'll try to check who could send the invites.

Thanks!

[alcohol]

I had to change lines 124-129 of the RelativeSlugHandler to get the same old behaviour we used to have.. any idea why?

  if (isset($this->usedOptions['urilize']) && $this->usedOptions['urilize']) {
      $slug = call_user_func_array(
          $this->originalTransliterator,
          [$slug, $separator, $object]
      );
      // <added>
      $slug = call_user_func_array(
          $this->sluggable->getUrlizer(),
          [$slug, $separator, $object]
      );
      // </added>
  }

[mbabker]

I had to change lines 124-129 of the RelativeSlugHandler to get the same old behaviour we used to have.. any idea why?

Probably the same reason I had to add the getUrlizer() call a few lines above that (#2944 (review) for reference). It looks like that code branch has no test coverage, but it probably should be fixed here.

[alcohol]

Yeah I was also thinking there might be a test scenario missing. Haven't had time to dive into this further yet though.