use FQCN as default type name

Author: syl20b

src/DependencyInjection/Compiler/RegisterDbalTypePass.php

@@ -12,7 +12,6 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
 
-use function array_key_exists;
 use function is_subclass_of;
 use function method_exists;
 use function sprintf;
@@ -50,10 +49,6 @@ public function process(ContainerBuilder $container): void
 
         foreach ($this->findTaggedResourceIds($container) as $id => $tags) {
             foreach ($tags as $tag) {
-                if (! array_key_exists('name', $tag)) {
-                    throw new InvalidArgumentException(sprintf('The "name" attribute is mandatory for the "doctrine.dbal.type" tag on the "%s" type.', $id));
-                }
-
                 $class = $container->getDefinition($id)->getClass();
                 if (! $class) {
                     throw new InvalidArgumentException(sprintf('The definition of "%s" must define its class.', $id));
@@ -63,7 +58,7 @@ public function process(ContainerBuilder $container): void
                     throw new InvalidArgumentException(sprintf('The "%s" class must extends "%s".', $class, Type::class));
                 }
 
-                $types[$tag['name']] = ['class' => $class];
+                $types[$tag['name'] ?? $class] = ['class' => $class];
             }
         }
 

tests/DependencyInjection/Compiler/RegisterDbalTypePassTest.php

@@ -31,7 +31,7 @@ public function testTaggedTypeAreAdded(): void
         self::assertSame(['bar' => ['class' => BarType::class]], $container->getParameter('doctrine.dbal.connection_factory.types'));
     }
 
-    public function testTagMustHaveANameAttribute(): void
+    public function testUseClassnameAsTypeNameIfNotDefined(): void
     {
         $container = new ContainerBuilder();
         $container->addCompilerPass(new RegisterDbalTypePass());
@@ -42,12 +42,9 @@ public function testTagMustHaveANameAttribute(): void
             ->addTag('doctrine.dbal.type')
             ->addTag('container.excluded');
 
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage(
-            sprintf('The "name" attribute is mandatory for the "doctrine.dbal.type" tag on the "%s" type.', BarType::class),
-        );
-
         $container->compile();
+
+        self::assertSame([BarType::class => ['class' => BarType::class]], $container->getParameter('doctrine.dbal.connection_factory.types'));
     }
 
     public function testTypeMustBeASubclassOfTheDbalBaseType(): void