rename tag attribute name to type_name due to Yaml limitation

Author: syl20b

src/DependencyInjection/Compiler/RegisterDbalTypePass.php

@@ -29,7 +29,7 @@ final class RegisterDbalTypePass implements CompilerPassInterface
     public static function autoconfigureFromAttribute(ChildDefinition $definition, AsDatabaseType $type, ReflectionClass $reflector): void
     {
         $attributes = [
-            'name' => $type->name ?? $reflector->name,
+            'type_name' => $type->name ?? $reflector->name,
         ];
 
         // Determine if the version of symfony/dependency-injection is >= 7.3
@@ -58,14 +58,14 @@ public function process(ContainerBuilder $container): void
                     throw new InvalidArgumentException(sprintf('The "%s" class must extends "%s".', $class, Type::class));
                 }
 
-                $types[$tag['name'] ?? $class] = ['class' => $class];
+                $types[$tag['type_name'] ?? $class] = ['class' => $class];
             }
         }
 
         $container->setParameter('doctrine.dbal.connection_factory.types', $types);
     }
 
-    /** @return array<string, array<array{name?: string}>> */
+    /** @return array<string, array<array{type_name?: string}>> */
     private function findTaggedResourceIds(ContainerBuilder $container): array
     {
         // Determine if the version of symfony/dependency-injection is >= 7.3

tests/DependencyInjection/Compiler/RegisterDbalTypePassTest.php

@@ -23,7 +23,7 @@ public function testTaggedTypeAreAdded(): void
         $container->setParameter('doctrine.dbal.connection_factory.types', []);
 
         $container->register(BarType::class)
-            ->addTag('doctrine.dbal.type', ['name' => 'bar'])
+            ->addTag('doctrine.dbal.type', ['type_name' => 'bar'])
             ->addTag('container.excluded');
 
         $container->compile();
@@ -55,7 +55,7 @@ public function testTypeMustBeASubclassOfTheDbalBaseType(): void
         $container->setParameter('doctrine.dbal.connection_factory.types', []);
 
         $container->register(NotASubClassOfDbalBaseType::class)
-            ->addTag('doctrine.dbal.type', ['name' => 'invalid_type'])
+            ->addTag('doctrine.dbal.type', ['type_name' => 'invalid_type'])
             ->addTag('container.excluded');
 
         $this->expectException(InvalidArgumentException::class);

tests/DependencyInjection/DoctrineExtensionTest.php

@@ -953,7 +953,7 @@ public static function cacheConfigurationProvider(): array
 
     /** @param class-string $typeClassname */
     #[DataProvider('provideDatabaseTypeAttribute')]
-    public function testAsDatabaseTypeAttribute(string $typeClassname, string $expectedName): void
+    public function testAsDatabaseTypeAttribute(string $typeClassname, string $expectedTypeName): void
     {
         $container = $this->getContainer();
         $extension = new DoctrineExtension();
@@ -977,7 +977,7 @@ public function testAsDatabaseTypeAttribute(string $typeClassname, string $expec
 
         $attributes[AsDatabaseType::class]($definition, $attribute, $reflector);
 
-        $expected = ['name' => $expectedName];
+        $expected = ['type_name' => $expectedTypeName];
         $this->assertSame([$expected], $definition->getTag('doctrine.dbal.type'));
         $this->assertSame([['source' => 'by tag "doctrine.dbal.type"']], $definition->getTag('container.excluded'));
     }
@@ -986,8 +986,8 @@ public function testAsDatabaseTypeAttribute(string $typeClassname, string $expec
     public static function provideDatabaseTypeAttribute(): array
     {
         return [
-            'with name' => [DbalType::class, 'dbal_type'],
-            'without name' => [DbalTypeNoName::class, DbalTypeNoName::class],
+            'with type name' => [DbalType::class, 'dbal_type'],
+            'without type name' => [DbalTypeNoName::class, DbalTypeNoName::class],
         ];
     }