use service Id as type name

Author: syl20b

src/DependencyInjection/Compiler/RegisterDbalTypePass.php

@@ -58,7 +58,7 @@ public function process(ContainerBuilder $container): void
                     throw new InvalidArgumentException(sprintf('The "%s" class must extends "%s".', $class, Type::class));
                 }
 
-                $types[$tag['type_name'] ?? $class] = ['class' => $class];
+                $types[$tag['type_name'] ?? $id] = ['class' => $class];
             }
         }
 

tests/DependencyInjection/Compiler/RegisterDbalTypePassTest.php

@@ -31,20 +31,21 @@ public function testTaggedTypeAreAdded(): void
         self::assertSame(['bar' => ['class' => BarType::class]], $container->getParameter('doctrine.dbal.connection_factory.types'));
     }
 
-    public function testUseClassnameAsTypeNameIfNotDefined(): void
+    public function testServiceIdMustBeUsedAsTypeNameIfNotDefined(): void
     {
         $container = new ContainerBuilder();
         $container->addCompilerPass(new RegisterDbalTypePass());
 
         $container->setParameter('doctrine.dbal.connection_factory.types', []);
 
-        $container->register(BarType::class)
+        $container->register('doctrine.dbal.type.bar')
+            ->setClass(BarType::class)
             ->addTag('doctrine.dbal.type')
             ->addTag('container.excluded');
 
         $container->compile();
 
-        self::assertSame([BarType::class => ['class' => BarType::class]], $container->getParameter('doctrine.dbal.connection_factory.types'));
+        self::assertSame(['doctrine.dbal.type.bar' => ['class' => BarType::class]], $container->getParameter('doctrine.dbal.connection_factory.types'));
     }
 
     public function testTypeMustBeASubclassOfTheDbalBaseType(): void