Wire PostgreSqlNotifyOnIdleListener for doctrine-messenger#2198
Conversation
30d377f to
20aac04
Compare
|
(help wanted for the remaining failures 🙏 ) |
20aac04 to
0d86280
Compare
|
And now the build fails because of https://github.com/sebastianbergmann/phpunit/releases/tag/12.5.11, and that will need to be fixed on 2.19.x I think |
|
There is also a failure that if (\in_array($resourceStore, ['flock', 'semaphore'], true)) {
$storeDefinitionId = \sprintf('.lock.%s.store', $resourceStore);
$storeDefinitions[] = new Reference($storeDefinitionId);
continue;
}
This one needs to be fixed on 3.2.x |
|
@alli83 Hi! Maybe you can help with this issue? I see that the LockStoreSchemaListener skips non-DBAL stores, so maybe the failing test is not testing what it should? DoctrineBundle/tests/LockStoreSchemaListenerTest.php Lines 75 to 78 in 1d5c4f3 It checks that we inject lock stores, but it only cares about the DBAL ones, however the |
…nd semaphore stores when they're used (nicolas-grekas) This PR was merged into the 8.1 branch. Discussion ---------- [FrameworkBundle] Properly set tag "lock.store" on flock and semaphore stores when they're used | Q | A | ------------- | --- | Branch? | 8.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Found while working doctrine/DoctrineBundle#2198 (comment) with `@greg0ire` Commits ------- 3047961 [FrameworkBundle] Properly set tag "lock.store" on flock and semaphore stores when they're used
0d86280 to
7d8fd21
Compare
|
Failure fixed by symfony/symfony#63361 |
|
Merge up PR: #2201 |
7d8fd21 to
ac8cafe
Compare
|
Haha you were on the starting blocks |
|
All green! |
|
Thanks @nicolas-grekas ! |
Sidekick of symfony/symfony#47666
Adapted from d-ph@ae224f3 by @d-ph