Skip to content

Wire PostgreSqlNotifyOnIdleListener for doctrine-messenger#2198

Merged
greg0ire merged 1 commit into
doctrine:3.3.xfrom
nicolas-grekas:msg-pglistener
Feb 13, 2026
Merged

Wire PostgreSqlNotifyOnIdleListener for doctrine-messenger#2198
greg0ire merged 1 commit into
doctrine:3.3.xfrom
nicolas-grekas:msg-pglistener

Conversation

@nicolas-grekas
Copy link
Copy Markdown
Member

Sidekick of symfony/symfony#47666
Adapted from d-ph@ae224f3 by @d-ph

@nicolas-grekas nicolas-grekas force-pushed the msg-pglistener branch 2 times, most recently from 30d377f to 20aac04 Compare February 10, 2026 07:55
@nicolas-grekas
Copy link
Copy Markdown
Member Author

(help wanted for the remaining failures 🙏 )

Comment thread src/DependencyInjection/DoctrineExtension.php Outdated
Comment thread config/messenger.php
@greg0ire
Copy link
Copy Markdown
Member

greg0ire commented Feb 11, 2026

And now the build fails because of https://github.com/sebastianbergmann/phpunit/releases/tag/12.5.11, and that will need to be fixed on 2.19.x I think

@greg0ire
Copy link
Copy Markdown
Member

#2199

@greg0ire
Copy link
Copy Markdown
Member

greg0ire commented Feb 11, 2026

There is also a failure that seems is (I commented out the lines you added @nicolas-grekas) caused by symfony/symfony@7951263

if (\in_array($resourceStore, ['flock', 'semaphore'], true)) {
                    $storeDefinitionId = \sprintf('.lock.%s.store', $resourceStore);
                    $storeDefinitions[] = new Reference($storeDefinitionId);
                    continue;
                }
  1. Doctrine\Bundle\DoctrineBundle\Tests\LockStoreSchemaListenerTest::testLockStoreSchemaSubscriberWiring#1 with data (['flock'], 1)
    Failed asserting that actual size 0 matches expected size 1.

This one needs to be fixed on 3.2.x

@greg0ire
Copy link
Copy Markdown
Member

@alli83 Hi! Maybe you can help with this issue? I see that the LockStoreSchemaListener skips non-DBAL stores, so maybe the failing test is not testing what it should?

$this->assertCount(
$expectedCount,
$container->findDefinition('test_subscriber_lock_alias')->getArguments()[0]->getValues(),
);

It checks that we inject lock stores, but it only cares about the DBAL ones, however the flock lock store is not DBAL based I think.

nicolas-grekas added a commit to symfony/symfony that referenced this pull request Feb 12, 2026
…nd semaphore stores when they're used (nicolas-grekas)

This PR was merged into the 8.1 branch.

Discussion
----------

[FrameworkBundle] Properly set tag "lock.store" on flock and semaphore stores when they're used

| Q             | A
| ------------- | ---
| Branch?       | 8.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Found while working doctrine/DoctrineBundle#2198 (comment) with `@greg0ire`

Commits
-------

3047961 [FrameworkBundle] Properly set tag "lock.store" on flock and semaphore stores when they're used
@nicolas-grekas
Copy link
Copy Markdown
Member Author

Failure fixed by symfony/symfony#63361

@greg0ire
Copy link
Copy Markdown
Member

Merge up PR: #2201

@greg0ire greg0ire closed this Feb 12, 2026
@greg0ire greg0ire reopened this Feb 12, 2026
@greg0ire
Copy link
Copy Markdown
Member

Haha you were on the starting blocks

@nicolas-grekas
Copy link
Copy Markdown
Member Author

All green!

@greg0ire greg0ire added this to the 3.3.0 milestone Feb 13, 2026
@greg0ire greg0ire merged commit 76433a2 into doctrine:3.3.x Feb 13, 2026
13 checks passed
@greg0ire
Copy link
Copy Markdown
Member

Thanks @nicolas-grekas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants