From a4d9ae0bd88b6b279cfbf2137d0f77951ed02c07 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Fri, 27 Feb 2026 22:54:38 +0100 Subject: [PATCH] Don't use FQCN as service ids --- config/dbal.php | 11 ++++++++--- .../Compiler/RemoveProfilerControllerPass.php | 3 +-- src/DependencyInjection/DoctrineExtension.php | 6 ------ templates/Collector/db.html.twig | 2 +- 4 files changed, 10 insertions(+), 12 deletions(-) diff --git a/config/dbal.php b/config/dbal.php index fdbfdea3c..51ec0533c 100644 --- a/config/dbal.php +++ b/config/dbal.php @@ -81,6 +81,11 @@ ->set('doctrine.dbal.schema_asset_filter_manager', SchemaAssetsFilterManager::class) ->abstract() + ->set('doctrine.manager_registry_aware_connection_provider', ManagerRegistryAwareConnectionProvider::class) + ->args([ + service('doctrine'), + ]) + ->set('doctrine.database_create_command', CreateDatabaseDoctrineCommand::class) ->args([ service('doctrine'), @@ -93,13 +98,13 @@ ]) ->tag('console.command', ['command' => 'doctrine:database:drop']) - ->set(RunSqlCommand::class) + ->set('doctrine.run_sql_command', RunSqlCommand::class) ->args([ - service(ManagerRegistryAwareConnectionProvider::class)->nullOnInvalid(), + service('doctrine.manager_registry_aware_connection_provider'), ]) ->tag('console.command', ['command' => 'dbal:run-sql']) - ->set(ProfilerController::class) + ->set('doctrine.profiler_controller', ProfilerController::class) ->args([ service('twig'), service('doctrine'), diff --git a/src/DependencyInjection/Compiler/RemoveProfilerControllerPass.php b/src/DependencyInjection/Compiler/RemoveProfilerControllerPass.php index acecf5283..927610810 100644 --- a/src/DependencyInjection/Compiler/RemoveProfilerControllerPass.php +++ b/src/DependencyInjection/Compiler/RemoveProfilerControllerPass.php @@ -4,7 +4,6 @@ namespace Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler; -use Doctrine\Bundle\DoctrineBundle\Controller\ProfilerController; use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; use Symfony\Component\DependencyInjection\ContainerBuilder; @@ -17,6 +16,6 @@ public function process(ContainerBuilder $container): void return; } - $container->removeDefinition(ProfilerController::class); + $container->removeDefinition('doctrine.profiler_controller'); } } diff --git a/src/DependencyInjection/DoctrineExtension.php b/src/DependencyInjection/DoctrineExtension.php index 0e2714d7a..b7ae76337 100644 --- a/src/DependencyInjection/DoctrineExtension.php +++ b/src/DependencyInjection/DoctrineExtension.php @@ -9,7 +9,6 @@ use Doctrine\Bundle\DoctrineBundle\Attribute\AsMiddleware; use Doctrine\Bundle\DoctrineBundle\CacheWarmer\DoctrineMetadataCacheWarmer; use Doctrine\Bundle\DoctrineBundle\ConnectionFactory; -use Doctrine\Bundle\DoctrineBundle\Dbal\ManagerRegistryAwareConnectionProvider; use Doctrine\Bundle\DoctrineBundle\Dbal\RegexSchemaAssetFilter; use Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\IdGeneratorPass; use Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\ServiceRepositoryCompilerPass; @@ -640,11 +639,6 @@ private function loadDbalConnection(string $name, array $connection, ContainerBu $def->setClass($options['wrapperClass']); } - $container->setDefinition( - ManagerRegistryAwareConnectionProvider::class, - new Definition(ManagerRegistryAwareConnectionProvider::class, [$container->getDefinition('doctrine')]), - ); - $configuration->addMethodCall('setSchemaManagerFactory', [new Reference($connection['schema_manager_factory'])]); if (! isset($connection['result_cache'])) { diff --git a/templates/Collector/db.html.twig b/templates/Collector/db.html.twig index 9d44f4fd2..2beb5124e 100644 --- a/templates/Collector/db.html.twig +++ b/templates/Collector/db.html.twig @@ -88,7 +88,7 @@ {% block panel %} {% if 'explain' == page %} - {{ render(controller('Doctrine\\Bundle\\DoctrineBundle\\Controller\\ProfilerController::explainAction', { + {{ render(controller('doctrine.profiler_controller::explainAction', { token: token, panel: 'db', connectionName: request.query.get('connection'),