Allow Doctrine ORM 4 on the 4.0.x branch#2227
Closed
wtorsi wants to merge 1 commit into
Closed
Conversation
The 4.0.x branch already requires `doctrine/dbal: ^4.0` and `doctrine/persistence: ^4`, signalling that this branch tracks the ORM 4 release line. However the `conflict` entry still blocks `doctrine/orm >=4.0`, which prevents installing this branch alongside `doctrine/orm: ^4.0@dev`. Lower the conflict's upper bound so the branch can be installed with ORM 4-dev. The lower bound `<3.0` is preserved.
Member
|
an upper bound should be kept |
Member
We do not keep major version numbers in sync across libraries. ORM 4 might allow DBAL 5 |
Author
Member
|
By bumping the upper bound to 5? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
4.0.xbranch already requiresdoctrine/dbal: ^4.0anddoctrine/persistence: ^4, signalling that this branch tracks the ORM 4 release line. However theconflictentry still blocksdoctrine/orm >=4.0, which prevents installing this branch alongsidedoctrine/orm: ^4.0@dev.This PR lowers the conflict's upper bound so the branch can be installed with ORM 4-dev. The lower bound
<3.0is preserved.Tested locally: with this change applied,
composer updateresolves cleanly for a Symfony bundle requiringdoctrine/orm: ^4.0@devtogether withdoctrine/doctrine-bundle: dev-4.0.x. Composer installsdoctrine/orm 4.0.x-dev,doctrine/dbal 4.4.x, anddoctrine/persistence 4.2.x(all stable except orm).Happy to adjust if maintainers prefer
<3.0 || >=5.0(orm 3 + 4 only) or the line removed entirely.