feat(rules): enforce catch exception order#383
Merged
Conversation
simPod
force-pushed
the
slevomat-catch-exceptions-order
branch
2 times, most recently
from
June 29, 2026 15:12
fee2969 to
14c6472
Compare
simPod
marked this pull request as ready for review
June 29, 2026 15:13
ostrolucky
previously approved these changes
Jun 29, 2026
greg0ire
reviewed
Jun 29, 2026
Member
|
Please squash the commits |
SenseException
approved these changes
Jun 29, 2026
simPod
force-pushed
the
slevomat-catch-exceptions-order
branch
from
June 30, 2026 06:06
cdc0d5b to
3770eb2
Compare
Contributor
Author
|
Done: the rule is ordered alphabetically and the branch is squashed to a single commit. |
ostrolucky
approved these changes
Jun 30, 2026
greg0ire
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Slevomat catch exception order rule and updates the fixtures/report expectations.
This is separate from #378: that PR was closed because we wanted to keep control over
@throwsannotation order. Catch exception order is a different case because it affects caught exception type ordering in code, not docblock annotation ordering.