Skip to content

Slevomat ReturnTypeHintSpacing: remove default spacesCountBeforeColon configuration#384

Merged
greg0ire merged 1 commit into
doctrine:15.0.xfrom
simPod:slevomat-returntypehintspacing-defaults
Jul 2, 2026
Merged

Slevomat ReturnTypeHintSpacing: remove default spacesCountBeforeColon configuration#384
greg0ire merged 1 commit into
doctrine:15.0.xfrom
simPod:slevomat-returntypehintspacing-defaults

Conversation

@simPod

@simPod simPod commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Resurrects #201 against 15.0.x.

This was changed to zero in #163, but this is the default, so there is no need for the override:
https://github.com/slevomat/coding-standard/blob/c4e287879af90a2f56b1b516deaba707858c9a24/SlevomatCodingStandard/Sniffs/TypeHints/ReturnTypeHintSpacingSniff.php#L35

The Slevomat maintainer also said this default will not change in the future.

Closes #201

…CountBeforeColon configuration that is the default
@simPod
simPod marked this pull request as ready for review July 1, 2026 08:42
@simPod
simPod requested a review from a team as a code owner July 1, 2026 08:42

@greg0ire greg0ire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no minor branch to contribute this to, and since we are going to release 15.0.x soonish, this is OK.

@greg0ire
greg0ire requested a review from a team July 1, 2026 18:10
@greg0ire greg0ire added this to the 15.0.0 milestone Jul 2, 2026
@greg0ire
greg0ire merged commit d5934ca into doctrine:15.0.x Jul 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants