No timeout in getUserInfo Function.

[devchanki]

src/ApiClient

version: 5.9.0-rc1

` exports.prototype.getUserInfo = function(accessToken, callback) {
if(!accessToken) throw new Error('Error accessToken is required',null);

var headers = {
  "Authorization": "Bearer " + accessToken,
  "Cache-Control": "no-store",
  "Pragma": "no-cache"
}

var request = superagent.get("https://" + this.getOAuthBasePath() + "/oauth/userinfo").set(headers);
var UserInfo = require('./OAuth').UserInfo;

if(!callback) {
  try {
    return new Promise(function (resolve, reject) {
      request.end(function (err, res) {
        if (err) {
          reject(err);
        } else {
          try {
            resolve(UserInfo.constructFromObject(res.body));
          } catch (error) {
            reject(error);
          }
        }
      });
    });
  } catch (err) {
    throw(err)
  }
} else {
  request.end(function (err, res) {
    if (err) {
      return callback(err, res);
    } else {
      return callback(err, UserInfo.constructFromObject(res.body));
    }
  });
}

};`

The timeout setting is not respected by some helper methods that make direct superagent calls instead of using the callApi wrapper. A clear example is the ApiClient.prototype.getUserInfo method, which does not provide a timeout option.

Some helper methods bypass the callApi wrapper and make direct superagent requests. For example, ApiClient.prototype.getUserInfo does not accept a timeout parameter, so the global timeout setting has no effect. If there is a way to set a timeout here, I would appreciate guidance.

thank you!

[esilva600]

Hello @devchanki

Yes, you're correct, isomg tje superagent.get(). will not let you define a timeout parameter explicitly, so you need to set it elsewhere.

To correct this, you can use the .timeout() method and add it to your getuserinfo method.

Here is a sample of how you can define the timeout settings:

var headers = {
"Authorization": "Bearer " + accessToken,
"Cache-Control": "no-store",
"Pragma": "no-cache"
}

var request = superagent.get("https://" + this.getOAuthBasePath() + "/oauth/userinfo").set(headers);

// Add this line to set a timeout (e.g., 10 seconds = 10000 ms)
if (timeout) {
request = request.timeout(timeout);
}

var UserInfo = require('./OAuth').UserInfo;

if(!callback) {
try {
return new Promise(function (resolve, reject) {
request.end(function (err, res) {
if (err) {
reject(err);
} else {
try {
resolve(UserInfo.constructFromObject(res.body));
} catch (error) {
reject(error);
}
}
});
});
} catch (err) {
throw(err)
}
} else {
request.end(function (err, res) {
if (err) {
return callback(err, res);
} else {
return callback(err, UserInfo.constructFromObject(res.body));
}
});
}

Cheers,

[devchanki]

Yeah, But It's in library code.