fix: format thread followers filter helper (prettier)

Author: dodaa08

apps/meteor/app/threads/server/functions.ts

@@ -1,13 +1,38 @@
 import type { IMessage, IRoom } from '@rocket.chat/core-typings';
 import { isEditedMessage } from '@rocket.chat/core-typings';
-import { Messages, Subscriptions, ReadReceipts, NotificationQueue, Rooms } from '@rocket.chat/models';
+import { Messages, NotificationQueue, ReadReceipts, Rooms, Subscriptions } from '@rocket.chat/models';
 
 import {
 	notifyOnSubscriptionChangedByRoomIdAndUserIds,
 	notifyOnSubscriptionChangedByRoomIdAndUserId,
 } from '../../lib/server/lib/notifyListener';
 import { getMentions, getUserIdsFromHighlights } from '../../lib/server/lib/notifyUsersOnMessage';
 
+async function filterUsersInRoom({ roomId, userIds, room }: { roomId: string; userIds: string[]; room: IRoom | null }): Promise<string[]> {
+	try {
+		if (!userIds.length || !room) {
+			return [];
+		}
+
+		if (room.t === 'd') {
+			return userIds.filter((userId) => room.uids?.includes(userId));
+		}
+
+		if (room.t === 'p' || room.t === 'c') {
+			const subscriptions = await Subscriptions.findByRoomIdAndUserIds(roomId, userIds, {
+				projection: { u: 1 },
+			}).toArray();
+
+			return subscriptions.filter((sub) => sub.u?._id).map((sub) => sub.u._id);
+		}
+
+		return [];
+	} catch (error) {
+		console.error('Error filtering users in room:', { roomId, error });
+		return [];
+	}
+}
+
 export async function reply({ tmid }: { tmid?: string }, message: IMessage, parentMessage: IMessage, followers: string[]) {
 	if (!tmid || isEditedMessage(message)) {
 		return false;
@@ -16,55 +41,19 @@ export async function reply({ tmid }: { tmid?: string }, message: IMessage, pare
 	const { rid, ts, u } = message;
 
 	const { toAll, toHere, mentionIds } = await getMentions(message);
-	
-	const filterUsersInRoom = async ({ 
-		roomId, 
-		userIds, 
-		room 
-	}: { 
-		roomId: string; 
-		userIds: string[]; 
-		room: IRoom | null 
-	}) => {
-		try {
-			
-			if (!userIds.length || !room) {
-				return [];
-			}
-
-			if (room.t === 'd') {
-				return userIds.filter((userId) => room.uids?.includes(userId));
-			}
-
-			if (room.t === 'p' || room.t === 'c') {
-				
-				const subscriptions = await Subscriptions.findByRoomIdAndUserIds(roomId, userIds, {
-					projection: { u: 1 },
-				}).toArray();
-				
-				return subscriptions.map((sub) => sub.u._id);
-			}
-
-			return [];
 
-		} catch (error) { 
-			console.error('Error filtering users in room:', { roomId, error });
-			return [];
-		}
-	}
-	
 	const room = await Rooms.findOneById(rid);
+
 	const [highlightsUids, threadFollowers] = await Promise.all([
 		getUserIdsFromHighlights(rid, message),
 		Messages.getThreadFollowsByThreadId(tmid),
 	]);
-	
-	
+
 	const [followersInRoom, mentionIdsInRoom, highlightsUidsInRoom] = await Promise.all([
 		filterUsersInRoom({ roomId: rid, userIds: followers, room }),
 		filterUsersInRoom({ roomId: rid, userIds: mentionIds, room }),
-		filterUsersInRoom({ roomId: rid, userIds: highlightsUids, room }),  // ← Add here
-	]);	
+		filterUsersInRoom({ roomId: rid, userIds: highlightsUids, room }),
+	]);
 
 	const addToReplies = [
 		...new Set([
@@ -76,14 +65,10 @@ export async function reply({ tmid }: { tmid?: string }, message: IMessage, pare
 
 	await Messages.updateRepliesByThreadId(tmid, addToReplies, ts);
 
-	
-
 	const threadFollowersUids = threadFollowers?.filter((userId) => userId !== u._id && !mentionIdsInRoom.includes(userId)) || [];
 
-	// Notify everyone involved in the thread
 	const notifyOptions = toAll || toHere ? { groupMention: true } : {};
 
-	// Notify message mentioned users and highlights
 	const mentionedUsers = [...new Set([...mentionIdsInRoom, ...highlightsUidsInRoom])];
 
 	const promises = [