You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.44%. Comparing base (5289d9d) to head (913c603). ⚠️ Report is 2 commits behind head on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the render-phase shared value warning reported in #829:
The warning was triggered when
getCurrentIndex()was called during React render (for example through an imperativerefread during rerender).1) Trigger chain
Carouselexposes imperativegetCurrentIndex()fromuseCarouselController.getCurrentIndex()readindex.valuedirectly.ref.current?.getCurrentIndex()during component render, Reanimated strict logger reports render-phase shared value access.2) Fix strategy
sharedIndex.current) as the source for imperative reads.getCurrentIndex()to readsharedIndex.currentinstead ofindex.value.syncSharedIndex()and update it innext/prev/topaths so imperative commands remain consistent immediately.3) Regression test
Added a warning-level regression test in
src/components/Carousel.test.tsx:Reading fromvalueduring component render.getCurrentIndex()read during render.This test is Red before the fix and Green after.
4) Validation
Executed:
yarn test src/components/Carousel.test.tsx src/hooks/useCarouselController.test.tsx src/components/Pagination/Pagination.test.tsx --runInBand --verbose=falseResult:
Notes
Closes #829.