You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
stabilize e2e/11-display-toggle-regression.yaml by using retry-based swipe blocks (repeat + while notVisible) and explicit focus taps on e2e-carousel
add a fast regression unit test in src/components/Carousel.test.tsx:
display toggle regression #885: should keep swipe working after hide/show layout cycle
verifies both behavior (0 -> 1 -> 2) and that Pan gesture instance is recreated after onLayout transitions from zero to positive size
implement a minimal fix in src/components/ScrollViewGesture.tsx:
track hidden layout state (layoutWasHidden)
when onLayout detects 0 -> >0, schedule a gestureEpoch bump on RN thread
include gestureEpoch in the pan-config callback dependency path to force pan gesture recreation
Why
When parent display toggles (none -> flex), the existing GestureDetector binding can remain stale. Recreating the Pan gesture instance on the first recovered non-zero layout restores swipe responsiveness without API changes.
Validation
Red before fix
yarn test src/components/Carousel.test.tsx --runInBand -t "display toggle regression #885"
failed before patch with:
expected pan creation count > 1
received 1
Green after fix
yarn test src/components/Carousel.test.tsx --runInBand -t "display toggle regression #885" ✅
yarn test src/components/Carousel.test.tsx --runInBand -t "Carousel sizing and measurement" ✅
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.47%. Comparing base (5289d9d) to head (9ffe5a0). ⚠️ Report is 2 commits behind head on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e/11-display-toggle-regression.yamlby using retry-based swipe blocks (repeat + while notVisible) and explicit focus taps one2e-carouselsrc/components/Carousel.test.tsx:display toggle regression #885: should keep swipe working after hide/show layout cycle0 -> 1 -> 2) and that Pan gesture instance is recreated afteronLayouttransitions from zero to positive sizesrc/components/ScrollViewGesture.tsx:layoutWasHidden)onLayoutdetects0 -> >0, schedule agestureEpochbump on RN threadgestureEpochin the pan-config callback dependency path to force pan gesture recreationWhy
When parent display toggles (
none -> flex), the existingGestureDetectorbinding can remain stale. Recreating the Pan gesture instance on the first recovered non-zero layout restores swipe responsiveness without API changes.Validation
Red before fix
yarn test src/components/Carousel.test.tsx --runInBand -t "display toggle regression #885"> 11Green after fix
yarn test src/components/Carousel.test.tsx --runInBand -t "display toggle regression #885"✅yarn test src/components/Carousel.test.tsx --runInBand -t "Carousel sizing and measurement"✅yarn biome check src/components/ScrollViewGesture.tsx src/components/Carousel.test.tsx e2e/11-display-toggle-regression.yaml✅E2E
APP_ID=com.react-native-reanimated-carousel.example maestro test e2e/11-display-toggle-regression.yaml0 devices connected).Closes #885.