fix: ensure useOnProgressChange responds to new offsetX and sizeReady…#905
Closed
gdvsbp wants to merge 2 commits into
Closed
fix: ensure useOnProgressChange responds to new offsetX and sizeReady…#905gdvsbp wants to merge 2 commits into
gdvsbp wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 5eddf43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@gdvsbp is attempting to deploy a commit to the Caspian's Team Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
Bot
added
size:XS
… instances Passing new offsetX or sizeReady instances to useOnProgressChange hook would not cause useAnimatedReaction hook to re-run despite it using those values. Adding those two shared values as dependencies of the hook.
Author
|
Closing in favor of #906 which goes against 4.x.x instead of main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… instances
Description
useOnProgressChangewill not re-runuseAnimatedReactionif newSharedValueinstances ofoffsetXorsizeReadyare passed as options because they do not exist inuseAnimatedReaction's dependency array.Ran into this issue at work and patched it in our project so I wanted to contribute the same fix back to the project.
Review
Testing
Saw
onProgressChangecalled with updated values when given new instances of shared values were passed