Skip to content

Module password#10

Open
lvolcov wants to merge 3 commits into
mainfrom
module-password
Open

Module password#10
lvolcov wants to merge 3 commits into
mainfrom
module-password

Conversation

@lvolcov
Copy link
Copy Markdown
Contributor

@lvolcov lvolcov commented Dec 30, 2020

No description provided.

Copy link
Copy Markdown
Contributor

@jampow jampow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O único item que vejo como obrigatório é a documentação do método, os outros estão abertos à discussão.

Comment thread src/622/modules/password/index.js
Comment thread src/622/modules/password/index.js Outdated
Comment thread src/622/modules/password/index.test.js Outdated
@jampow jampow added the enhancement New feature or request label Jan 2, 2021
@jampow
Copy link
Copy Markdown
Contributor

jampow commented Jan 3, 2021

@all-contributors please add @lvolcov for code, documentation, tests

@allcontributors
Copy link
Copy Markdown
Contributor

@jampow

I've put up a pull request to add @lvolcov! 🎉

@jampow jampow added this to the Versão 1.0.0 milestone Jan 3, 2021
Comment thread src/622/modules/password/index.js
jampow
jampow previously approved these changes Feb 8, 2021
@jampow jampow changed the base branch from master to main April 26, 2022 04:37
@jampow jampow dismissed their stale review April 26, 2022 04:37

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants