Torii Plugin for Bevy WASM#2
Draft
elton-cs wants to merge 3 commits into
Draft
Conversation
Contributor
|
Thank you @elton-cs for the work here! As mentioned before in discord, it will be worthy trying to have everything with tokio, since it will be only one In the meantime, we could put each version of the plugin under a feature to be enabled based on the configuration that the user is attempting to use. Since the API will remain the same, it will then be possible to choose the plugin version based on the target. If you are willing to work on that, let's add a module with the stuff that is target independent, and conditionally include the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heyo!
Modified the Torii plugin to work on wasm using Bevy Async Tasks as opposed to using an external Tokio runtime.
Check it out and let's have some discussion on this.
Things to note:
This seems to be because Torii's implementation requires a Tokio runtime when compiling to native (probably because of the cfg directives). This may be a larger refactor to get both builds to use the exact same plugin implementation but not sure, would like some thoughts on this @glihm
Fortunately, they BOTH do work, so projects can use either depending on their build, just need to add/remove Tokio dep and import the appropriate plugin.