fix(indexer): make controller sync non-blocking for processing commit#401
Merged
Conversation
Controller sync failures now only log errors instead of propagating them, allowing the main processing to be committed regardless of controller sync status. - Changed join_controllers_sync to return () instead of Result - Removed unused ControllerSync error variant - Added error metrics for controller sync failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Controller sync failures now only log errors instead of propagating them, allowing the main processing to be committed regardless of controller sync status.
Changes
join_controllers_syncto return()instead ofResultControllerSyncerror variant fromerror.rsBehavior Change
Before: If controller sync failed, it would return an error, prevent
storage.execute()from being called, and cause the processing to be rolled back.After: If controller sync fails, it will log the error, increment the error counter metric, and continue with
storage.execute()to commit the processing. Processing is no longer affected by controller sync failures.