Skip to content

fix(runner): relax Starknet RPC spec version check #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kariy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(runner): relax Starknet RPC spec version check #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions crates/runner/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,14 +291,25 @@ impl Runner {
);
let provider: Arc<_> = JsonRpcClient::new(transport).into();

// Check provider spec version. We only support v0.9.
// Check provider spec version. Torii supports v0.9.0; a mismatch is non-fatal.
let supported_spec = "0.9";
let spec_version = provider.spec_version().await?;
if !spec_version.starts_with(supported_spec) {
return Err(anyhow::anyhow!(
"Provider spec version is not supported. Please use a provider that supports v{supported_spec}. Got: {spec_version}. You might need to add a `rpc/v{}` to the end of the URL.",
supported_spec.replace('.', "_")
));
match provider.spec_version().await {
Ok(spec_version) => {
if !spec_version.starts_with(supported_spec) {
warn!(
target: LOG_TARGET,
spec_version = %spec_version,
"Provider spec version mismatch. Torii supports v0.9.0. Continuing anyway; you may experience unexpected behaviours.",
);
}
}
Err(e) => {
warn!(
target: LOG_TARGET,
error = ?e,
"Could not query Starknet RPC spec version. Torii supports v0.9.0. Continuing anyway; you may experience unexpected behaviours.",
);
}
}

// Verify contracts are deployed
Expand Down
Loading