Skip to content

np : allow same user in a multi-session environment (Windows Server)#1330

Open
lanopk wants to merge 1 commit intodokan-dev:masterfrom
lanopk:master
Open

np : allow same user in a multi-session environment (Windows Server)#1330
lanopk wants to merge 1 commit intodokan-dev:masterfrom
lanopk:master

Conversation

@lanopk
Copy link
Copy Markdown

@lanopk lanopk commented Mar 20, 2026

Fixes # .

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the existing documentation
  • My changes generate no new warnings
  • I have updated the change log (Add/Change/Fix)
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

We have modified the Network Provider to allow requests from the same user in a multi-session environment (Windows Server).
This may also be helpful when user sessions change.
Please refer to the issue below.
#1328 (comment)

@lanopk
Copy link
Copy Markdown
Author

lanopk commented Apr 10, 2026

It failed the verification. What should I do?
You can simply review the modified parts and edit the code yourself.

@LTRData
Copy link
Copy Markdown
Contributor

LTRData commented Apr 10, 2026

  • FOSSA License Compliance issues detect that we are using WiX Toolset libraries which are under MIT or MS-RL license while Dokany is under LGPL, which violates LGPL compliance. LGPL practically only allows other LGPL licensed libraries. I guess this might be possible to solve by changing the dependency tree such that nothing LGPL licensed depends on WiX but instead the other way around. It is after all not actually used by the Dokany library code. We probably need to look into this.

  • Appveyor build fails because git warns about normalizing line endings (LF-CRLF). This could in most cases be ignored at build servers. I'll see if I can modify the yml to add a command to simply stop doing this on the build server.

  • Codacy complains that wtsapi32.h is not found. That is really strange. I wonder if something about Windows SDK setup is wrong in the configuration there. But it seems I cannot see any configuration there, @Liryna maybe?

@LTRData
Copy link
Copy Markdown
Contributor

LTRData commented Apr 10, 2026

More about appveyor. If I am not mistaken, it should be possible to solve by adding this to appveyor.yml:

  init:
    - git config --global core.autocrlf false
    - git config --global core.safecrlf false

And possibly also add a .gitattributes file with:

* -text

@lanopk
Copy link
Copy Markdown
Author

lanopk commented Apr 11, 2026

For reference, the SDKs I used for testing were Windows SDK 10.0.19041.0, 10.0.26100.0, etc., and I built it with Visual Studio 2024. (Because I didn't have Visual Studio 2019)

@LTRData
Copy link
Copy Markdown
Contributor

LTRData commented Apr 11, 2026

For reference, the SDKs I used for testing were Windows SDK 10.0.19041.0, 10.0.26100.0, etc., and I built it with Visual Studio 2024. (Because I didn't have Visual Studio 2019)

Yes, this is most probably an issue with configuration on the build server. Not something in your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants