fix: honor explicit restart: false in dokku_config#383
Merged
josegonzalez merged 1 commit intoJul 16, 2026
Merged
Conversation
An explicit `restart: false` in a `dokku_config` recipe was silently overridden back to `true`, so `dokku config:set` and `config:unset` restarted the app despite the opt-out and the documented no-restart example restarted the app anyway. The explicit value is now honored on both the set and unset paths, and the other optional boolean task flags that carry a default are made consistent so a future default value cannot regress the same way.
josegonzalez
deleted the
308-bug-dokku-config-restart-false-is-silently-overridden-to-true
branch
July 16, 2026 07:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit
restart: falsein adokku_configrecipe was silently overridden back totrue, sodokku config:setandconfig:unsetrestarted the app despite the opt-out and the documented no-restart example restarted the app anyway. The explicit value is now honored on both the set and unset paths, and the other optional boolean task flags that carry a default are made consistent so a future default value cannot regress the same way.Closes #308