fix: run tag filtering after --start-at-task gate#384
Merged
josegonzalez merged 1 commit intoJul 16, 2026
Merged
Conversation
Tag filtering previously ran before the `--start-at-task` gate, so a `--start-at-task` target excluded by `--tags`/`--skip-tags` was removed before the gate could resume, leaving every surviving task skipped as `before --start-at-task` and the run exiting 0 having changed nothing. Tags now narrow the survivors after the resume point is selected, matching the filter order documented in the flag help and command reference.
josegonzalez
deleted the
315-bug-tag-filtering-runs-before-start-at-task-and-can-silently-no-op-the-run
branch
July 16, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag filtering ran before the
--start-at-taskgate, the reverse of the order documented in the flag help and command reference (--start-at-taskselects first, then--tags/--skip-tags). When the--start-at-tasktarget was itself excluded by the tag filter, it was removed before the gate could resume, so thestartedflag never flipped, every surviving task printed[skipped] (before --start-at-task), and the run exited 0 having changed nothing.With tasks
first [tags: x],second [tags: y],third [tags: x]anddocket apply --start-at-task second --tags x, the documented order selectssecondandthird, then narrows by tags to runthird. The run now does this: the resume point is selected first and tags narrow the survivors, so a target excluded by tags still establishes the resume point without running itself.Closes #315.