fix: stop probe from swallowing local exec errors#391
Merged
josegonzalez merged 1 commit intoJul 18, 2026
Merged
Conversation
`Probe` converted every non-`SSHError` failure into `(false, nil)`, so a missing `dokku` binary or a cancelled probe was reported as absent and `plan` printed a confident `[+] create` for every resource and exited 0 instead of rendering `[!]` and exiting 1. It now treats only a command that actually ran and exited non-zero as absent, propagating any failure that means the probe never produced an answer.
josegonzalez
deleted the
328-bug-probe-swallows-local-exec-errors-and-reports-resources-as-absent
branch
July 18, 2026 01:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probeconverted every non-SSHErrorfailure into(false, nil), so on a machine withoutdokkuonPATHand no configured host every exit-code probe was reported as absent.docket planthen printed a confident[+] createfor every resource and exited 0 (or 2 with--detailed-exitcode) instead of rendering[!]and exiting 1, so it never predicted the failure thatapplyhits at the first task that cannot run.Probe now treats only a command that actually ran and exited non-zero as state absent, and propagates any failure that means the probe never produced an answer - a missing binary, a permission error, a cancellation, or a transport failure - so
planrenders[!]and exits 1 as the command reference already promises.Closes #328.