fix: sort resource and ps-scale command arguments#393
Merged
josegonzalez merged 1 commit intoJul 18, 2026
Merged
Conversation
The resource limit, resource reserve, and ps-scale tasks built their command arguments and mutation lists by ranging over a Go map, so the planned command could differ from the executed command and vary from run to run. Ordering the keys deterministically makes plan and apply render byte-identical `Commands` and produces a stable mutation order.
josegonzalez
deleted the
341-bug-planned-and-executed-resource-command-argument-order-can-differ
branch
July 18, 2026 03:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resource limit, resource reserve, and ps-scale tasks built their command arguments and mutation lists by ranging over a Go map, so the planned command could differ from the executed command and vary from run to run. This violated the byte-identical
Commandscontract that plan output andapply --verboseare meant to share, and produced noisy, non-reproducible mutation ordering.Ordering the keys deterministically makes plan and apply render byte-identical commands and produces a stable mutation order. The other map-carrying tasks such as
dokku_configalready sort their keys, and list-based tasks such asdokku_portspreserve the authored order, so they are unaffected.Fixes #341.