fix: mark in-place storage mount drift as a modify#394
Merged
josegonzalez merged 1 commit intoJul 18, 2026
Conversation
The present-state planner hardcoded `PlanStatusCreate` even when an existing attachment was found and only `volume_options` drifted, so `docket plan` rendered the in-place remediation with the `+` create marker instead of the `~` modify marker. It now reports `PlanStatusModify` on the existing-attachment branch, matching sibling tasks such as `service_expose`. This affects only plan rendering; `apply` runs the same command and is unchanged.
josegonzalez
deleted the
343-bug-storage-mount-plan-shows-a-create-marker-for-an-in-place-volume-options-change
branch
July 18, 2026 04:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The present-state planner hardcoded
PlanStatusCreateeven when an existing attachment was found and onlyvolume_optionsdrifted, sodocket planrendered the in-place remediation with the+create marker instead of the~modify marker. It now reportsPlanStatusModifyon the existing-attachment branch, matching sibling tasks such asservice_expose. This affects only plan rendering;applyruns the same command and is unchanged.Fixes #343.