fix: route probe warnings through the event emitter#397
Merged
josegonzalez merged 1 commit intoJul 18, 2026
Conversation
Property probe diagnostics were written with `log.Printf`, bypassing both the secret masking and the event emitter that every other user-facing message uses. As a result `--json` runs never saw a `warning` event and one branch echoed raw server stderr unmasked. They now surface as typed, masked warning events and aligned `[warning]` lines correlated with their task, and the maintenance custom-page export warning is routed through the same masked channel.
josegonzalez
deleted the
353-bug-property-task-warnings-use-log-printf-and-bypass-masking-and-the-event-emitter
branch
July 18, 2026 05:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Property probe diagnostics were written with
log.Printf, bypassing both the secret masking and the event emitter that every other user-facing message uses. As a result--jsonruns never saw awarningevent and one branch echoed raw server stderr unmasked. They now surface as typed, masked warning events and aligned[warning]lines correlated with their task, and the maintenance custom-page export warning is routed through the same masked channel.Fixes #353