Fix for code scanning alert no. 2: Incorrect conversion between integer types#400
Merged
Conversation
…ween integer types Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
josegonzalez
marked this pull request as ready for review
July 18, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/dokku/docket/security/code-scanning/2
The safest no-functional-change fix is to parse directly into a signed 32-bit integer and convert that to
rune, instead of parsing unsigned then narrowing.Specifically in
tasks/json5_dup.go, insidereadString()at thecase 'u':block:strconv.ParseUint(..., 16, 32)withstrconv.ParseInt(..., 16, 32).if err == nilflow and character consumption logic unchanged.rune(r)whereris nowint64, which is a signed-to-signed narrowing toint32under a 32-bit parse bound and satisfies the CodeQL concern raised for unsigned-to-int32 conversion.No new imports or helper methods are needed;
strconvis already imported.Suggested fixes powered by Copilot Autofix. Review carefully before merging.