[pull] master from php:master#843
Merged
Merged
Conversation
#22374) Reduced temporary allocations when iterating Phar directories.
Calling Collator::__construct() or Spoofchecker::__construct() on an already constructed object replaces the stored ICU handle, which leaves the previous handle unreachable and prevents it from being released during object destruction. Reject repeated construction with an Error for both classes so the existing ICU handle remains owned by the object. Add PHPT coverage for the double construction path. Closes #22386
* PHP-8.4: ext/intl: Fix double construction leaks (#22386)
* PHP-8.5: ext/intl: Fix double construction leaks (#22386)
…2386) PHP-8.5 no longer declares a zend_error_handling variable in Spoofchecker::__construct(). The previous merge from PHP-8.4 carried forward a zend_replace_error_handling() call that references the removed local variable. Remove the stale call so PHP-8.5 and branches merged from it build again.
* PHP-8.5: ext/intl: Fix Spoofchecker build after double construction change (#22386)
…on section Move the Locale::lookup() and double-construction leak NEWS entries from the previous release section to the current unreleased section. These fixes landed after the previous release and should be listed under the next one.
* PHP-8.4: [skip ci] Fix NEWS entry for several Intl fixes into the latest version section
* PHP-8.5: [skip ci] Fix NEWS entry for several Intl fixes into the latest version section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )