[pull] master from php:master#889
Merged
Merged
Conversation
…php (#22597) getPathName() was called instead of the correctly-cased getPathname().
…l() (#22598) Avoid duplicating the namespace-separator split logic.
None of these files have use the sys/param.h file.
) sleep(4294967296) actually sleep 0 seconds because of a unsigned int overflow bug. This is also true in usleep. I target this to master as a fix that is classified as a stricter parsing. Now we throw ValueError instead. p.s. in Windows, the sleep function is implemented with SleepEx (t * 1000, TRUE) not php_sleep, phew, so we need to lower the threshold to UINT_MAX / 1000 in Windows
…nd (#22582) shift_operator_helper() wrote ZVAL_UNDEF(return_value) on the out-of-range exponent/shift path, but for a compound assignment return_value aliases op1, so pow_function's fallback then reached the scalar conversion with op1 set to IS_UNDEF and hit ZEND_UNREACHABLE(). Drop the stray undef; the helper's other error paths already return FAILURE without touching return_value, leaving the operand intact for the thrown ValueError to propagate. Fixes GH-22549
uriparser 1.0.3 has to be released containing some missing symbols in order to be able to build PHP with the "--with-external-uriparser" option. Closes #22553
Sometimes running `./configure` for ASAN hangs on my machine. This is
reproducible when compiling and running the program manually using
clang-16 -g -fsanitize=undefined,address test.c
It seems this is related to the LLVM symbolizer getting stuck, and the
symbolizer is likely required to report the memory leak. After adding the
memory management functions it seems to work (or rather fail) reliably.
This macro is very rarely used and badly named by neither including the `IS` nor the `AST` in its name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )