AutoUpdateChecker: Fix Edge Cases#14532
Merged
Dentomologist merged 2 commits intoMay 5, 2026
Merged
Conversation
Ignore any new update check requests if one is already in progress.
Don't set `s_update_triggered` if the updater process fails to be created. This will allow users in that situation to try to start an update later without having to restart Dolphin first.
JoshuaVandaele
approved these changes
Apr 17, 2026
Contributor
Author
|
Unless somebody wants more time to review this I'm planning to merge it in a day or two, both to unblock #14533 and to make sure both PRs get merged with plenty of time for testing before the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some edge cases in the update checking logic:
Prevent multiple update checks from happening at the same time. If a user started a check right after starting Dolphin they could end up with one
Update availablewindow from the manual check and a second window at the same time from the startup check.If the user checks for an update when one is already pending, show a message explaining that.
Don't set the
s_update_triggeredflag if the updater process fails to start. This allows users in this situation to try again later without having to restart Dolphin first.